chore: update line-bot-sdk-go to v8.22.0 and rewrite README - #31
Merged
Conversation
- Bump github.com/line/line-bot-sdk-go/v8 from v8.10.0 to v8.22.0 - Bump go directive to 1.25 (required by the new SDK) and update the +heroku goVersion pragma to match - Update CI to setup-go@v5 with Go 1.25 so it can still build - Rewrite README: fix typos, document required env vars and the local dev / ngrok flow, add a "make it your own" section pointing at the event loop, and tidy the deploy steps for Render and Heroku
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the template up to the latest LINE Messaging API SDK, modernizes
main.gofor the Go version that comes with it, and gives the README a pass.SDK / toolchain
github.com/line/line-bot-sdk-go/v8: v8.10.0 → v8.22.0go.modgo directive: 1.23 → 1.25 — v8.22.0 declaresgo 1.25, so this is required, not optional// +heroku goVersionpragma updated fromgo1.21togo1.25to matchactions/setup-go@v4→@v5, pinned Go1.21→1.25(the old pin could no longer build the new SDK)The SDK bump itself needed no source changes —
main.gocompiled against v8.22.0 unmodified.Go modernization
Checked
main.goagainst the Modern Go Guidelines for Go 1.25; two applied:"POST /callback"rather than"/callback". LINE only ever POSTs to the webhook, so anything else now gets a 405 from the mux instead of falling into the handler and failing signature parsing.cmp.Or: thePORTfallback collapses from a four-line empty-string check tocmp.Or(os.Getenv("PORT"), "5000").README
devloper,Rener,Hoe to)ChannelSecret,ChannelAccessToken, optionalPORT)go run+ngroktunnel flow, which was missing entirelyTest plan
go build ./...go vet ./...gofmt -l .cleango test ./...(no test files in this repo)